pitrou commented on a change in pull request #10390:
URL: https://github.com/apache/arrow/pull/10390#discussion_r641563788
##########
File path: docs/source/cpp/compute.rst
##########
@@ -310,6 +310,20 @@ output element is null.
| less, less_equal | |
| |
+--------------------------+------------+---------------------------------------------+---------------------+
+These functions take any number of inputs of numeric type (in which case they
+will be cast to the :ref:`common numeric type <common-numeric-type>` before
+comparison) or of temporal types. If any input is dictionary encoded it will be
+expanded for the purposes of comparison.
+
++--------------------------+------------+---------------------------------------------+---------------------+---------------------------------------+-------+
+| Function names | Arity | Input types
| Output type | Options class | Notes |
++==========================+============+=============================================+=====================+=======================================+=======+
+| maximum, minimum | Varargs | Numeric and Temporal
| Numeric or Temporal | :struct:`ElementWiseAggregateOptions` | \(1) |
Review comment:
It just came to my mind that it's gonna be very confusing to have
"minimum" and "maximum" functions in addition to "min_max". Perhaps we can be
less ambiguous, e.g. "scalar_min", "scalar_max" (or "horizontal_min" or
"row_min"...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
