MarkCruz911 commented on PR #51630: URL: https://github.com/apache/arrow/pull/51630#issuecomment-6425518380
Thanks for the clarification, @raulcd, and for taking the time to review this. I understand the review workload, and I appreciate your help. I see what you meant now: splitting the documentation into "dataset" and "limits" did not fully consolidate the shared parameters, since ParquetFile still documented several of them separately. I've pushed an update with the following changes: Replaced the dictionary with a single _read_docstring_common string containing the shared parameter documentation, including read_dictionary, binary_type, list_type, memory_map, buffer_size, pre_buffer, and the reader limits. Factored out only partitioning into _read_docstring_dataset, since it does not apply to ParquetFile. Reused the complete common block in ParquetFile, ParquetDataset, and _read_table_docstring, removing the corresponding duplicated descriptions. Updated the existing joins in read_table.__doc__ and read_pandas.__doc__ to use _read_docstring_dataset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
