AlenkaF commented on PR #55264: URL: https://github.com/apache/arrow/pull/55264#issuecomment-6442437688
I have run `pytest pyarrow-stubs/tests`, no errors found. I have looked through the tests also and tried to break some, everything looks good. I think the tests are easy to follow while still cover a lot of different angles. I have also run mypy's stubtest with `stubtest pyarrow.lib --concise --mypy-config-file pyproject.toml`. All of the reported discrepancies are cases of "... is not present in stub" with majority of them being stubs that are not yet included in this PR (scalars, io, etc.). Part of these are also `Type_*` stubs, for example `pyarrow.lib.Type_UINT8`. As we already have `TypesEnum` defined here, might it make sense to also include `Type_*` stubs now? (I am not inclined towards adding them, just wondering). Besides the reports mentioned above which will be fixed in subsequent PRs, stubtest did found one bug in pyarrow: ``` pyarrow.lib.Decima32Array is not present in stub ``` Note missing "L" in "Decimal". I will work on the fix for this now and would suggest to add it as part of this PR. Can commit directly, if that is ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
