HippoBaro commented on code in PR #11971:
URL: https://github.com/apache/arrow-rs/pull/11971#discussion_r4408355862
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -1404,11 +1471,12 @@ impl ArrowRowGroupWriterFactory {
file_writer: &SerializedFileWriter<W>,
arrow_schema: SchemaRef,
) -> Self {
- let schema = Arc::clone(file_writer.schema_descr_ptr());
+ let schema_plan =
+
ArrowWriteSchemaPlan::try_new(file_writer.schema_descr_ptr().as_ref(),
&arrow_schema)
+ .map(Arc::new);
Review Comment:
Damn, thanks for catching that. I fixed the error type in
97447bdd378766c8646c8d5f844803d9f567ac80, but left the API question open for
discussion.
@alamb, I know you generally prefer avoiding breaking changes. Do you have a
preference here? It feels like (2) mostly delays the inevitable, so I’m
inclined to bite the bullet now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
