adriangb commented on code in PR #11971:
URL: https://github.com/apache/arrow-rs/pull/11971#discussion_r4408380036
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -1404,11 +1471,12 @@ impl ArrowRowGroupWriterFactory {
file_writer: &SerializedFileWriter<W>,
arrow_schema: SchemaRef,
) -> Self {
- let schema = Arc::clone(file_writer.schema_descr_ptr());
+ let schema_plan =
+
ArrowWriteSchemaPlan::try_new(file_writer.schema_descr_ptr().as_ref(),
&arrow_schema)
+ .map(Arc::new);
Review Comment:
I think it's worth doing a quick (AI assisted) survey of call-sites at least
in DataFusion. But I agree it's worth just biting the bullet and making the
breaking change (1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
