AlenkaF commented on code in PR #51631:
URL: https://github.com/apache/arrow/pull/51631#discussion_r4444547876
##########
python/pyarrow/io.pxi:
##########
@@ -193,6 +193,20 @@ cdef class NativeFile(_Weakrefable):
else:
check_status(self.output_stream.get().Close())
+ def abort(self):
Review Comment:
Yes, I think your reading is correct and yes documenting the behavior would
be best. Couple of things I would mention:
- the stream is always closed. For PythonFile, the wrapped object stays open,
- the behavior is implementation-dependent, keeping the information about S3
streams but also noting that data is not guaranteed to be flushed or discarded
in general,
I also think the test should be updated to reflect this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
