adrien-grl commented on code in PR #51631:
URL: https://github.com/apache/arrow/pull/51631#discussion_r4442903793
##########
python/pyarrow/io.pxi:
##########
@@ -193,6 +193,20 @@ cdef class NativeFile(_Weakrefable):
else:
check_status(self.output_stream.get().Close())
+ def abort(self):
Review Comment:
Thank you very much for your review! `Abort()` is documented in
`interfaces.h` as:
> Close the stream abruptly
>
> This method does not guarantee that any pending data is flushed. It merely
releases any underlying resource used by the stream for its operation.
I verified it, and `PythonFile::Abort()` follows this as it only releases
its reference to the Python file and doesn't call `close()` on it. I also
verified that with the `FSSpecHandler` fixtures the data still gets written as
soon as it's closed (but `abort()` doesn't close it itself). Do you have any
suggestion about what to do? Should I document this behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
