Rich-T-kid commented on code in PR #12084:
URL: https://github.com/apache/arrow-rs/pull/12084#discussion_r4486678540
##########
arrow-ipc/src/compression.rs:
##########
@@ -431,6 +495,27 @@ mod tests {
);
}
+ #[test]
+ #[cfg(feature = "lz4")]
+ fn test_lz4_compression_reuses_context() {
Review Comment:
This verifies correctness across repeated frames, but it would also pass if
every call created a fresh encoder. Is there a stable way to assert that the
same cached compressor is retained across calls? maybe we could assert the
capacity?
we could also keep this test and rename it to
`test_lz4_compression_multiple_frames` and create a separate test to assert the
allocation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
