gabotechs commented on code in PR #12084:
URL: https://github.com/apache/arrow-rs/pull/12084#discussion_r4490200446
##########
arrow-ipc/src/compression.rs:
##########
@@ -431,6 +495,27 @@ mod tests {
);
}
+ #[test]
+ #[cfg(feature = "lz4")]
+ fn test_lz4_compression_reuses_context() {
Review Comment:
🤔 FrameEncoder does not expose an API to inspect its internal buffer, so I
don't think we can assert over the capacity. I could start comparing pointer
addresses of the FrameEncoder, but I fear that'd make a brittle test in case
someone changes something in the future.
What comes to mind is:
- Rename the test as you suggested, and rely on it for ensuring correctness
rather than reuse
- Rely on the benchmark added in the previous PR for ensuring reuse (no
reuse would show worst performance)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
