Rich-T-kid commented on code in PR #11912:
URL: https://github.com/apache/arrow-rs/pull/11912#discussion_r4468797756
##########
arrow-row/src/fixed.rs:
##########
@@ -356,16 +356,27 @@ fn split_off<'a>(src: &mut &'a [u8], len: usize) -> &'a
[u8] {
}
/// Decodes a `BooleanArray` from rows
+#[expect(dead_code, reason = "Preserve the existing infallible decoder API")]
pub fn decode_bool(rows: &mut [&[u8]], options: SortOptions) -> BooleanArray {
Review Comment:
true, forgot that pub doesn't always mean user facing
##########
arrow-row/src/fixed.rs:
##########
@@ -356,16 +356,27 @@ fn split_off<'a>(src: &mut &'a [u8], len: usize) -> &'a
[u8] {
}
/// Decodes a `BooleanArray` from rows
+#[expect(dead_code, reason = "Preserve the existing infallible decoder API")]
pub fn decode_bool(rows: &mut [&[u8]], options: SortOptions) -> BooleanArray {
Review Comment:
true, forgot that `pub` doesn't always mean user facing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
