Jefffrey commented on code in PR #11912:
URL: https://github.com/apache/arrow-rs/pull/11912#discussion_r4465142912
##########
arrow-row/src/fixed.rs:
##########
@@ -356,16 +356,27 @@ fn split_off<'a>(src: &mut &'a [u8], len: usize) -> &'a
[u8] {
}
/// Decodes a `BooleanArray` from rows
+#[expect(dead_code, reason = "Preserve the existing infallible decoder API")]
pub fn decode_bool(rows: &mut [&[u8]], options: SortOptions) -> BooleanArray {
Review Comment:
i dont think this is public, we can just remove; same for the others below
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
@@ -419,7 +419,11 @@ impl FixedSizeBinaryArray {
///
/// # Errors
///
- /// Returns error if argument has length zero, or sizes of nested slices
don't match.
+ /// - The iterator is empty
+ /// - The byte slices have different lengths
+ /// - The value length exceeds `i32`
+ /// - Size arithmetic overflows
+ /// - Buffer allocation fails
Review Comment:
can we avoid any changes to this deprecated function; we're going to remove
it later anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
