paleolimbot commented on code in PR #986:
URL: https://github.com/apache/arrow-nanoarrow/pull/986#discussion_r4534300985
##########
src/nanoarrow/ipc/encoder_test.cc:
##########
@@ -108,6 +108,55 @@ TEST(NanoarrowIpcTest, NanoarrowIpcFooterEncoding) {
EXPECT_GT(footer_buffer->size_bytes, raw_schema_buffer->size_bytes);
}
+// Fill a stretch of the stack so that uninitialized stack bytes used by a
+// subsequent call are not zero by chance
+#if defined(_MSC_VER)
+__declspec(noinline)
+#else
Review Comment:
I appreciate the thoroughness here, but this test still passes in most cases
even without the fix. I think this PR is stronger without the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
