hcrosse opened a new pull request, #1547: URL: https://github.com/apache/arrow-go/pull/1547
### Rationale for this change This fixes the boolean part of #1537. On main, `ReadTable` returned recovered panic text, while `SeekToRow` and parallel `Next` panicked on worker goroutines and ended the process. ### What changes are included in this PR? Before building a decoder, `configureDict` returns the error message that Arrow C++ uses in `MakeDictDecoder`. This covers page processing and dictionary loading during a seek. https://github.com/apache/arrow/blob/976779b2aac587f51b87c3bd2e6ae4c36f75ab6c/cpp/src/parquet/decoder.cc#L2800-L2805 ### Are these changes tested? `TestReadDictionaryEncodedBooleanReturnsError` covers `ReadTable`, `NextParallel` and `SeekToRow`. The test builds the dictionary encoded boolean file with the page writer because the file writer never dictionary encodes `BOOLEAN`. All three rows fail on main and pass with this change. With Go 1.26.10, I ran vet, race tests for `parquet/file` and `parquet/pqarrow`, full `./parquet/...` tests with pinned `arrow-testing` and `parquet-testing` checked out, `golangci-lint` 2.13.2 and the Release Audit Tool. All passed. ### Are there any user-facing changes? Yes. Reads of `BOOLEAN` columns with a dictionary page return an error instead of panicking. There is no API change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
