Dandandan commented on a change in pull request #470:
URL: https://github.com/apache/arrow-datafusion/pull/470#discussion_r644331235
##########
File path: datafusion/src/optimizer/hash_build_probe_order.rs
##########
@@ -187,6 +187,7 @@ impl OptimizerRule for HashBuildProbeOrder {
| LogicalPlan::CreateExternalTable { .. }
| LogicalPlan::Explain { .. }
| LogicalPlan::Union { .. }
+ | LogicalPlan::Join { .. }
Review comment:
I think the only way the compiler can do it now is by explicitly
matching on all the join types, but as this feature is not added
https://github.com/rust-lang/rfcs/blob/master/text/2535-or-patterns.md that
would be quite verbose currently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
