Ayush-CS-89112521 commented on PR #12149: URL: https://github.com/apache/arrow-rs/pull/12149#issuecomment-6874759788
Thanks @Rich-T-kid! Updated the PR as per your feedback: - **Doc Example**: Updated the docstring example to showcase that all 3 elements are identical (`value(0)`, `value(1)`, `value(2)`). - **`# Errors` Docs**: Updated the error documentation on both `GenericByteArray::try_new_repeated` and `OffsetBuffer::try_from_repeated_length` to explicitly mention buffer allocation failures. - **Simplified Tests**: Consolidated the unit tests to test `BinaryArray` directly, removing the redundant type cases as suggested. Verified locally (`cargo test -p arrow-array`, `cargo test -p arrow-buffer`, clippy, and typos). Would appreciate your review on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
