Sumdiboii opened a new pull request, #55637:
URL: https://github.com/apache/arrow/pull/55637
### Rationale for this change
I have been studying the Apache Arrow codebase for the past couple of weeks
and am still relatively new to open source. I had my first documentation fix
merged a couple of days ago, and while continuing to read through the C++ and
Parquet code, I noticed a few small cleanup opportunities in the
content-defined chunking tests and related documentation comments.
These changes are intentionally small and do not alter production behavior.
They improve readability, remove an unnecessary copy, and clean up an
accidental duplicate assertion.
### What changes are included in this PR?
- Fix three spelling errors in C++ comments:
- `preceeding` to `preceding`
- `specifed` to `specified`
- `determinisic` to `deterministic`
- `lenght` to `length`
- Replace `diffs.size() == 0` with `diffs.empty()` in the page-length
assertion helpers. This expresses the intent more directly and is the idiomatic
way to check whether a container has no elements.
- Remove a duplicated dictionary-page assertion in
`AssertContentDefinedChunkSizes`.
The duplicate initially caught my attention because I was unsure whether
the two identical assertions were intended as some kind of additional failure
protection. After looking into the helper's callers, the original commit, and
GoogleTest's assertion behavior, I found that both assertions checked exactly
the same condition. Since `ASSERT_EQ` is fatal and returns from the helper when
it fails, the second assertion would never run after a failure in the first
one. When the first assertion passes, the second one does not provide any
additional coverage, so it was redundant.
- Change the local `page_lengths` variable to a `const` reference to avoid
copying the page-length vector unnecessarily.
### Are these changes tested?
No runtime tests were run. The changes are limited to comments and small
test-code cleanups, with no production behavior or public API changes.
`git diff --check` was run successfully though. A focused C++ test build was
not available in the checkout, so the Parquet test suite was not run locally.
### Are there any user-facing changes?
No. These are test and comment cleanups only.
### Was AI used for this PR?
AI was used to help search through the codebase, investigate the history and
behavior of the duplicated assertion, and review the proposed small cleanup
changes. The changes and reasoning were all reviewed before submission.
**PR code and description written by:**
- [x] Human
- [x] AI
**Reviewed before submission by:**
- [x] Human
- [ ] AI
- [ ] Not reviewed
Note - The duplicated assertion seemed redundant based on the current helper
behavior and GoogleTest's fatal assertion semantics. If it was originally
intended to serve a purpose that I have overlooked, please let me know and I
would be happy to revise my change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]