zeroshade commented on code in PR #1597:
URL: https://github.com/apache/arrow-go/pull/1597#discussion_r4604311597


##########
parquet/pqarrow/file_writer.go:
##########
@@ -509,11 +510,12 @@ func (fw *FileWriter) Close() error {
                // sink is closed
                err := fw.wr.Close()
                if rgErr != nil {
-                       return rgErr
+                       fw.closeErr = rgErr
+               } else {
+                       fw.closeErr = err
                }
-               return err
        }
-       return nil
+       return fw.closeErr

Review Comment:
   Nit: the doc comment on `Close` above still says "subsequent calls after the 
first will have no effect". That is no longer accurate, because later calls now 
return the error from the first call, including when `Write` has already closed 
the writer after a failure. Maybe: "Subsequent calls do nothing and return the 
error from the first call."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to