andreinknv commented on issue #909:
URL: 
https://github.com/apache/arrow-rs-object-store/issues/909#issuecomment-6958468895

   Some details in case they help. (#292 and #908 cover `humantime`, 
RUSTSEC-2026-0542; this is only about chrono.)
   
   chrono is part of the public API, so removing it needs a breaking release:
   
   - `ObjectMeta::last_modified: DateTime<Utc>`;
   - `GetOptions::{if_modified_since, if_unmodified_since}` and 
`with_if_modified_since` / `with_if_unmodified_since(Option<impl 
Into<DateTime<Utc>>>)`.
   
   Internally it handles HTTP dates, SigV4/SAS timestamps, token expiry and the 
Azure CLI's local-time `expiresOn`.
   
   Proposal: For the next breaking release, move the internal uses to jiff 1 
(MSRV 1.85, same as `object_store`), with the same byte-for-byte HTTP and 
signing formats. For the public types, either:
   
   1. `std::time::SystemTime`: no third-party type in the API. Both libraries 
convert from it with `From`, so `with_if_modified_since(Some(chrono_datetime))` 
keeps compiling and readers use `DateTime::<Utc>::from(meta.last_modified)`; or
   2. `jiff::Timestamp`: a direct replacement, but every chrono-based caller 
must convert.
   
   I lean towards (1) because it causes the least churn for chrono-based 
dependents.
   
   Alternatives considered:
   
   - Keep chrono and have every downstream ignore the advisory.
   - A chrono feature flag: struct field types cannot depend on a feature.
   
   I have a working branch for (2), [branch 
`jiff-timestamps`](https://github.com/andreinknv/arrow-rs-object-store/tree/jiff-timestamps):
 16 files, +146/−164, with the humantime parts left to #908. Test expectations 
are unchanged. It passes the clippy feature matrix and dependency checks from 
`ci.yml`, `cargo test --features=aws,azure,gcp,http` (331 passed), the wasm 
builds and `cargo +1.85.0 check`. Switching it to (1) only changes the 
conversions at the `ObjectMeta` / `GetOptions` boundary. I can open a PR for 
whichever option you prefer.
   
   AI disclosure (per the Arrow guidance on AI-generated code): this text and 
the branch were drafted with an AI coding assistant (Claude Code). I reviewed 
them and ran the checks above.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to