alberttwong opened a new pull request, #1599:
URL: https://github.com/apache/arrow-go/pull/1599

   ### Rationale for this change
   
   The `ExportRecordReader` comment says the caller does not need to release 
the reader, but `exportStream` retains a separate reference and the stream 
release callback releases that reference. Following the existing comment can 
leave the caller's original reference unreleased.
   
   Refs #1548. This is the comment clarification suggested in the maintainer's 
reply; it does not attempt to close the broader benchmarking request.
   
   ### What changes are included in this PR?
   
   Clarify that the C stream retains its own reader reference, the caller 
remains responsible for releasing its reference (which it may do immediately 
after export), and the consumer must release the stream to drop the stream's 
reference.
   
   ### Are these changes tested?
   
   - `go test -count=1 -p 1 -race -tags assert,test ./arrow/cdata` — passed on 
darwin/arm64 with Go 1.27.2.
   - `git diff --check` — passed.
   - Checked the wording against `exportStream`, `streamRelease`, and 
`cRecordReader.release`.
   
   ### Are there any user-facing changes?
   
   Corrected API documentation only; no runtime behavior or API changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to