hcrosse opened a new pull request, #1601:
URL: https://github.com/apache/arrow-go/pull/1601

   ### Rationale for this change
   
   After `Skip` or `SeekToRow`, V1 pages can reuse the previous page's 
repetition levels (#1521). On both versions, a second skip can also drop the 
rest of a page, and `Skip` after `ReadBatch` shifts the levels.
   
   I reproduced this on main, with Go 1.26.10 on macOS arm64.
   
   ### What changes are included in this PR?
   
   `initLevelDecodersV1` clears `repLvlBuffer` when a repeated page starts. 
`skipRows` decodes the rest of the page's levels into `repLvlBuffer` once, at 
their page positions, and scans from `numDecoded`. A decode error leaves the 
buffer empty.
   
   ### Are these changes tested?
   
   Every case of `TestSkipAndSeekRepeatedAcrossPages` fails on main for V1. For 
V2, every case fails except seeking to the start of the next page. 
`TestRecordReaderSeekToRowRepeated` fails only for V1. Both tests pass with 
this change.
   
   I ran `go test -count=1 -race -tags assert,test ./parquet/...` with pinned 
test data and `golangci-lint` 2.13.2 in `parquet/` on linux/amd64. Both passed. 
Focused tests also passed on macOS arm64.
   
   ### Are there any user-facing changes?
   
   Yes. Reads of repeated columns after these `Skip` and `SeekToRow` calls 
return the right rows. There is no API change.
   
   Closes #1521
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to