cetra3 opened a new pull request, #12308:
URL: https://github.com/apache/arrow-rs/pull/12308

   # Which issue does this PR close?
   
   - Part of #11511
   
   This is the first of a stack of PRs that split #11511 into smaller pieces, 
as its reviewers asked.
   
   # Rationale for this change
   
   #11511 adds header-only views of encoded variant bytes. The views read 
offsets and field names straight from the encoded buffer, and these helpers are 
in the way of that. This PR makes the helper changes on their own, so that the 
later PRs only show the views.
   
   # What changes are included in this PR?
   
   - `OffsetSizeBytes::unpack_u32_at_offset` takes `self` by value. 
`OffsetSizeBytes` is `Copy`.
   - `OffsetSizeBytes::unpack_u32` is removed. It was `unpack_u32_at_offset` 
with a byte offset of 0, and its callers now call that.
   - `str_from_bytes` is extracted from `string_from_slice`, which now calls it.
   
   All of these items are crate-private.
   
   # Are these changes tested?
   
   The existing tests cover the changed code. The `unpack_u32` tests now call 
`unpack_u32_at_offset`.
   
   # Are there any user-facing changes?
   
   No.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to