ViktorBystrov72 opened a new pull request, #55666:
URL: https://github.com/apache/arrow/pull/55666

   ### Rationale for this change
   
   Fixes #55636. `logb(0, base)` returned negative infinity for bases between 
zero and one, and for NaN or infinite bases.
   
   ### What changes are included in this PR?
   
   For zero input, the unchecked kernel returns positive infinity for finite 
bases between zero and one, negative infinity for finite bases at least one, 
and NaN for nonpositive or nonfinite bases. The kernel determines these results 
without evaluating a logarithm at zero.
   
   ### Are these changes tested?
   
   The new assertions failed on the original C++ kernel for both float and 
double. After the fix, the scalar math test executable reported 595 passed and 
28 skipped. The C++ formatting and lint checks also passed.
   
   ### Are there any user-facing changes?
   
   The corrected results are visible through the C++ compute function and 
`pyarrow.compute.logb`.
   
   ### Was AI used for this PR?
   
   Codex generated the C++ change, regression test, and PR description and 
reviewed the patch and test results.
   
   **PR code and description written by**
   
   - [ ] Human
   - [x] AI
   
   **Reviewed before submission by**
   
   - [ ] Human
   - [x] AI
   - [ ] Not reviewed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] GH-55636: [C++] Fix logb ... ViktorBystrov72 (via GitHub) via github

Reply via email to