thisisnic commented on code in PR #55594:
URL: https://github.com/apache/arrow/pull/55594#discussion_r4632724135
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3745,12 +3745,24 @@ function(build_google_cloud_cpp_storage)
TRUE
PARENT_SCOPE)
- # Workaround missing BCRYPT_RSA_ALG_HANDLE macro in older MinGW-w64 headers.
- # google-cloud-cpp v3+ uses it without guards in sign_using_sha256.cc.
+ # Workaround missing BCRYPT_RSA_ALG_HANDLE and BCRYPT_MD5_ALG_HANDLE macros
+ # in older MinGW-w64 headers. google-cloud-cpp v3+ uses them without guards.
Review Comment:
Nah, even newer RTools has older MinGW-w64 headers, we'd have to do it for
all of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]