romainfrancois commented on pull request #10445:
URL: https://github.com/apache/arrow/pull/10445#issuecomment-856892875


   Interesting, we could make that opt-in. For now it's all happening here so 
would be easy enough to make conditional: 
   
   ```cpp
   // [[arrow::export]]
   SEXP Array__as_vector(const std::shared_ptr<arrow::Array>& array) {
     auto type = array->type();
   
   #if defined(HAS_ALTREP)
     if (array->null_count() == 0) {
       switch (type->id()) {
         case arrow::Type::DOUBLE:
           return arrow::r::Make_array_nonull_dbl_vector(array);
         case arrow::Type::INT32:
           return arrow::r::Make_array_nonull_int_vector(array);
           // case arrow::Type::INT64:
           //   return arrow::r::Make_array_nonull_int64_vector(array);
   
         default:
           break;
       }
     }
   #endif
   
     return arrow::r::ArrayVector__as_vector(array->length(), type, {array});
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to