alamb commented on a change in pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581#discussion_r654552043
##########
File path: .github/workflows/rust.yml
##########
@@ -349,9 +349,7 @@ jobs:
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- # 2020-11-15: There is a cargo-tarpaulin regression in 0.17.0
- # see https://github.com/xd009642/tarpaulin/issues/618
- cargo install --version 0.16.0 cargo-tarpaulin
+ cargo install --version 0.18.0-alpha3 cargo-tarpaulin
Review comment:
I don't understand this change. It seems to cause an error in CI,
right?:
https://github.com/apache/arrow-datafusion/pull/581/checks?check_run_id=2858343109
Maybe we could put the old version of tarpaulin back?
##########
File path: datafusion/src/logical_plan/dfschema.rs
##########
@@ -248,12 +248,14 @@ where
}
impl ToDFSchema for Schema {
+ #[allow(clippy::wrong_self_convention)]
Review comment:
I don't understand the suggestion
##########
File path: .github/workflows/rust.yml
##########
@@ -349,9 +349,7 @@ jobs:
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- # 2020-11-15: There is a cargo-tarpaulin regression in 0.17.0
- # see https://github.com/xd009642/tarpaulin/issues/618
- cargo install --version 0.16.0 cargo-tarpaulin
+ cargo install --version 0.18.0-alpha3 cargo-tarpaulin
Review comment:
I see -- in that case it does seem like disabling code coverage until it
is fixed is the right thing to do, and we can file an issue to re-enable it
once whatever underlying issue is fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
