Jimexist commented on a change in pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581#discussion_r654185047
##########
File path: datafusion/src/logical_plan/dfschema.rs
##########
@@ -248,12 +248,14 @@ where
}
impl ToDFSchema for Schema {
+ #[allow(clippy::wrong_self_convention)]
Review comment:
maybe it's a better idea to remove
https://github.com/apache/arrow-datafusion/pull/581/files#diff-54ef5cfee73dd6cdbd9186bbf5931f4e375ccf002f956d1fe8bf35deafaf56a6R244
##########
File path: .github/workflows/rust.yml
##########
@@ -349,9 +349,7 @@ jobs:
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- # 2020-11-15: There is a cargo-tarpaulin regression in 0.17.0
- # see https://github.com/xd009642/tarpaulin/issues/618
- cargo install --version 0.16.0 cargo-tarpaulin
+ cargo install --version 0.18.0-alpha3 cargo-tarpaulin
Review comment:
It was failing either way so this line diff was my attempt to fix it in
vain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
