rok commented on a change in pull request #10507:
URL: https://github.com/apache/arrow/pull/10507#discussion_r655248209
##########
File path: r/R/dplyr-functions.R
##########
@@ -442,3 +442,37 @@ nse_funcs$strptime <- function(x, format = "%Y-%m-%d
%H:%M:%S", tz = NULL, unit
Expression$create("strptime", x, options = list(format = format, unit =
unit))
}
+
+nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start =
getOption("lubridate.week.start", 7)) {
+ if (label) {
+ arrow_not_supported("Label argument")
Review comment:
We could do such things in C++ as the library we use supports
locale-aware [strftime](https://strftime.org/) (See [slide
26](http://schd.ws/hosted_files/cppcon2016/0f/Welcome%20To%20The%20Time%20Zone%20-%20Howard%20Hinnant%20-%20CppCon%202016.pdf).
I expect we'll need it other places later too.
Please make a Jira and indicate we need to discuss if this goes into R or
C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
