thisisnic commented on a change in pull request #10507:
URL: https://github.com/apache/arrow/pull/10507#discussion_r655221384
##########
File path: r/R/dplyr-functions.R
##########
@@ -442,3 +442,37 @@ nse_funcs$strptime <- function(x, format = "%Y-%m-%d
%H:%M:%S", tz = NULL, unit
Expression$create("strptime", x, options = list(format = format, unit =
unit))
}
+
+nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE, week_start =
getOption("lubridate.week.start", 7)) {
+ if (label) {
+ arrow_not_supported("Label argument")
Review comment:
The label argument allows the return of the day of the week in the
correct language.
In `lubridate`, there's a whole lot of work around defining the locale and
then setting the weekday names appropriately, though essentially, it just uses
the format function to extract the relevant date.
I think that we wouldn't want to implement this at the C++ level as it
doesn't feel like it fits there as it's doing quite a lot more work than
calculating a value, (i.e. returning locale-specific dates), and we could still
achieve this with good performance at the R level by implementing this
functionality using the ifelse kernel once its R bindings are implemented.
How about if I leave it as unsupported now, but create a ticket to implement
it later, that lists the ifelse R binding as a dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
