alamb opened a new pull request #532:
URL: https://github.com/apache/arrow-rs/pull/532


   # Which issue does this PR close?
   Re: https://github.com/apache/arrow-rs/issues/529
   
   # Rationale for this change
    The current CI test 
([here](https://github.com/apache/arrow-rs/blob/master/.github/workflows/rust.yml#L371))
 to ensure arrow builds with various feature flags did not catch #529. This is 
because it is run in the context of the overall workspace which does not behave 
the same way as when arrow is used as a dependency
   
   This PR contains the test strategy I propose to use for testing that arrow 
properly builds with different options. I plan a follow on PR that actually 
fixed #529
   
   # What changes are included in this PR?
   
   This PR contains the test strategy I propose to use for testing that arrow 
properly builds with different options. I plan a follow on PR that actually 
fixed #529
   
   # Changes
   1. Create actual projects that specify `arrow` as a dependency with various 
flags
   2. Try to build that project in CI
   
   You easily run these builds locally:
   ```shell
   cd arrow/test/dependency/no-features
   cargo check
   ```
   
   I am sure there is some clever tool somewhere that claims to solve this 
problem (perhaps `cargo hack`? as suggested by @ritchie46). However, I chose to 
do it explicitly here because:
   1. It is as close as possible to how an actual user will build their app 
with arrow
   2. I can audit how it works without having to review projects and asses how 
mature / stable they are
   
   # Are there any user-facing changes?
   
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to