romainfrancois commented on a change in pull request #10730:
URL: https://github.com/apache/arrow/pull/10730#discussion_r672304332
##########
File path: r/src/array_to_vector.cpp
##########
@@ -133,6 +146,16 @@ class Converter {
protected:
std::shared_ptr<ChunkedArray> chunked_array_;
+
+ private:
+ bool CanAltrep(const std::shared_ptr<Array>& array) {
+ if (array->null_count() == 0) {
+ return true;
+ }
+
+ return array->data().use_count() == 1 &&
array->data()->buffers[1].use_count() == 1 &&
+ array->data()->buffers[1]->is_mutable();
Review comment:
specifically here when mutating does not logically change anything. it's
my understanding that what's there is undefined and that it is inconsequential
to change it.
it may be false however when the buffer comes from a source that prevents
mutation, I don't have a specific example but I guess reading from disk or
something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
