romainfrancois commented on a change in pull request #10730:
URL: https://github.com/apache/arrow/pull/10730#discussion_r672305324
##########
File path: r/tests/testthat/test-altrep.R
##########
@@ -59,52 +59,117 @@ test_that("altrep vectors from int32 and dbl arrays with
nulls", {
c_int <- ChunkedArray$create(c(1L, NA, 3L))
c_dbl <- ChunkedArray$create(c(1, NA, 3))
- # cannot be altrep because one NA
- expect_false(is_altrep_int_nonull(as.vector(v_int)))
- expect_false(is_altrep_int_nonull(as.vector(v_int$Slice(1))))
- expect_false(is_altrep_dbl_nonull(as.vector(v_dbl)))
- expect_false(is_altrep_dbl_nonull(as.vector(v_dbl$Slice(1))))
- expect_false(is_altrep_int_nonull(as.vector(c_int)))
- expect_false(is_altrep_int_nonull(as.vector(c_int$Slice(1))))
- expect_false(is_altrep_dbl_nonull(as.vector(c_dbl)))
- expect_false(is_altrep_dbl_nonull(as.vector(c_dbl$Slice(1))))
-
- # but then, no NA beyond, so can be altrep again
- expect_true(is_altrep_int_nonull(as.vector(v_int$Slice(2))))
- expect_true(is_altrep_dbl_nonull(as.vector(v_dbl$Slice(2))))
- expect_true(is_altrep_int_nonull(as.vector(c_int$Slice(2))))
- expect_true(is_altrep_dbl_nonull(as.vector(c_dbl$Slice(2))))
+ expect_true(is_altrep(as.vector(v_int)))
+ # expect_true(is_altrep(as.vector(v_int$Slice(1))))
+ expect_true(is_altrep(as.vector(v_dbl)))
+ # expect_true(is_altrep(as.vector(v_dbl$Slice(1))))
+ expect_true(is_altrep(as.vector(c_int)))
+ # expect_true(is_altrep(as.vector(c_int$Slice(1))))
+ expect_true(is_altrep(as.vector(c_dbl)))
+ # expect_true(is_altrep(as.vector(c_dbl$Slice(1))))
+
+ # expect_true(is_altrep(as.vector(v_int$Slice(2))))
+ # expect_true(is_altrep(as.vector(v_dbl$Slice(2))))
+ # expect_true(is_altrep(as.vector(c_int$Slice(2))))
+ # expect_true(is_altrep(as.vector(c_dbl$Slice(2))))
# chunked array with 2 chunks cannot be altrep
c_int <- ChunkedArray$create(0L, c(1L, NA, 3L))
c_dbl <- ChunkedArray$create(0, c(1, NA, 3))
expect_equal(c_int$num_chunks, 2L)
expect_equal(c_dbl$num_chunks, 2L)
- expect_false(is_altrep_int_nonull(as.vector(c_int)))
- expect_false(is_altrep_dbl_nonull(as.vector(c_dbl)))
- expect_true(is_altrep_int_nonull(as.vector(c_int$Slice(3))))
- expect_true(is_altrep_dbl_nonull(as.vector(c_dbl$Slice(3))))
+
+ expect_false(is_altrep(as.vector(c_int)))
+ expect_false(is_altrep(as.vector(c_dbl)))
+ # expect_true(is_altrep(as.vector(c_int$Slice(3))))
+ # expect_true(is_altrep(as.vector(c_dbl$Slice(3))))
})
test_that("empty vectors are not altrep", {
withr::local_options(list(arrow.use_altrep = TRUE))
v_int <- Array$create(integer())
v_dbl <- Array$create(numeric())
- expect_false(is_altrep_int_nonull(as.vector(v_int)))
- expect_false(is_altrep_dbl_nonull(as.vector(v_dbl)))
+ expect_false(is_altrep(as.vector(v_int)))
+ expect_false(is_altrep(as.vector(v_dbl)))
})
test_that("as.data.frame(<Table>, <RecordBatch>) can create altrep vectors", {
withr::local_options(list(arrow.use_altrep = TRUE))
table <- Table$create(int = c(1L, 2L, 3L), dbl = c(1, 2, 3))
df_table <- as.data.frame(table)
- expect_true(is_altrep_int_nonull(df_table$int))
- expect_true(is_altrep_dbl_nonull(df_table$dbl))
+ expect_true(is_altrep(df_table$int))
+ expect_true(is_altrep(df_table$dbl))
batch <- RecordBatch$create(int = c(1L, 2L, 3L), dbl = c(1, 2, 3))
df_batch <- as.data.frame(batch)
- expect_true(is_altrep_int_nonull(df_batch$int))
- expect_true(is_altrep_dbl_nonull(df_batch$dbl))
+ expect_true(is_altrep(df_batch$int))
+ expect_true(is_altrep(df_batch$dbl))
+})
+
+test_that("altrep min/max/sum identical to R versions for double", {
+ expect_altrep_rountrip <- function(x, fn, ...) {
+ expect_identical(fn(x, ...), fn(Array$create(x)$as_vector(), ...))
Review comment:
Thanks. I'll update to add more things to `expect_altrep_rountrip()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
