Dandandan commented on a change in pull request #813:
URL: https://github.com/apache/arrow-datafusion/pull/813#discussion_r682060480
##########
File path: datafusion/src/physical_plan/expressions/in_list.rs
##########
@@ -234,16 +363,40 @@ impl PhysicalExpr for InListExpr {
match value_data_type {
DataType::Float32 => {
- make_contains!(array, list_values, self.negated, Float32,
Float32Array)
+ make_contains_primitive!(
+ array,
+ list_values,
+ self.negated,
+ Float32,
+ Float32Array
+ )
}
DataType::Float64 => {
- make_contains!(array, list_values, self.negated, Float64,
Float64Array)
+ make_contains_primitive!(
+ array,
+ list_values,
+ self.negated,
+ Float64,
+ Float64Array
+ )
}
DataType::Int16 => {
- make_contains!(array, list_values, self.negated, Int16,
Int16Array)
+ make_contains_primitive!(
+ array,
+ list_values,
+ self.negated,
+ Int16,
+ Int16Array
+ )
}
DataType::Int32 => {
- make_contains!(array, list_values, self.negated, Int32,
Int32Array)
+ make_contains_primitive!(
+ array,
+ list_values,
+ self.negated,
+ Int32,
+ Int32Array
+ )
}
DataType::Int64 => {
make_contains!(array, list_values, self.negated, Int64,
Int64Array)
Review comment:
Oops, great catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
