edponce commented on a change in pull request #10896:
URL: https://github.com/apache/arrow/pull/10896#discussion_r684474220
##########
File path: cpp/src/arrow/compute/api_scalar.cc
##########
@@ -471,6 +478,10 @@ Result<Datum> CaseWhen(const Datum& cond, const
std::vector<Datum>& cases,
return CallFunction("case_when", args, ctx);
}
+Result<Datum> IsNull(const Datum& arg, const NanNullOptions& options,
ExecContext* ctx) {
+ return CallFunction("is_null", {arg}, &options, ctx);
Review comment:
This signature is different from the one exposed in `api_scalar.h`, this
results in linker error. Change to
```
Result<Datum> IsNull(const Datum& arg, NanNullOptions options, ExecContext*
ctx) {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
