edponce commented on a change in pull request #10896:
URL: https://github.com/apache/arrow/pull/10896#discussion_r691551801
##########
File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc
##########
@@ -77,17 +77,100 @@ TEST_F(TestBooleanValidityKernels, ArrayIsNull) {
"[true, false, false, true]");
}
+TEST_F(TestFloatValidityKernels, FloatArrayIsNull) {
+ // All NaN
Review comment:
I suggest to combine all the `TestFloatValidityKernels` tests into a
single block and similarly for the `TestDoubleValidityKernels`. You can use
comments to specify the type of test performed and change the options directly
(e.g., `options.nan_is_null = false`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
