westonpace opened a new pull request #22:
URL: https://github.com/apache/arrow-cookbook/pull/22
There are probably quite a few things to point out for discussion and jot
down for future issues:
* The C++ cookbook CI build is separate from the R & Python builds right
now. I think that is probably a good thing. It is fairly involved and
installs conda and other dependencies the other builds probably don't care
about.
* The C++ cookbook is not part of make all since it requires conda which
may not be present on user systems. I think in the future make all could be
updated to detect conda and, if present, build C++ or skip if not present
(Apache Thrift does something like this)
* The C++ cookbook uses a custom Sphinx extension which is a bit of
maintenance but, on the other hand, I couldn't find a really good plugin for
rendering AND testing C++ code blocks with Sphinx.
* The build uses "last released Arrow" and should use nightly (or multiple
Arrow versions)
* I think eventually BeginRecipe and EndRecipe will become macros so they
can include "minimum supported version". I'd really like them to be able to
define their own functions so you can do something like...
```
BEGIN_RECIPE(ReturnNotOk, 3.0.0)
void HelperFunc() {
}
void Recipe() {
}
END_RECIPE(ReturnNotOk)
```
...but also do something like this (no helper functions)...
```
BEGIN_RECIPE(Builder, 3.0.0)
arrow::IntBuilder builder;
END_RECIPE(Builder)
```
* Placeholder for other things I'm sure I've forgotten
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
