karldw commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r697645741



##########
File path: r/tests/testthat/test-install-arrow.R
##########
@@ -37,3 +37,20 @@ r_only({
     })
   })
 })
+
+
+r_only({
+  test_that("download_optional_dependencies", {
+    skip_if_offline()
+    deps_dir <- tempfile()
+    download_successful <- expect_output(
+      download_optional_dependencies(deps_dir),
+      "export ARROW_THRIFT_URL"

Review comment:
       I've deleted the test, but I'll leave this conversation open so we can 
talk about where to put the test in CI.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to