[GitHub] [arrow] kou commented on a change in pull request #11181: ARROW-14033: [Ruby][Doc] Add macOS development guide for Red Arrow

[GitBox]

kou commented on a change in pull request #11181:
URL: https://github.com/apache/arrow/pull/11181#discussion_r711799583



##########
File path: ruby/red-arrow/README.md
##########
@@ -50,3 +50,20 @@ table = Arrow::Table.load("/dev/shm/data.arrow")
 # Process data in table
 table.save("/dev/shm/data-processed.arrow")
 ```
+
+## development

Review comment:
       ```suggestion
   ## Development
   
   Note that you need to install Apache Arrow C++/GLib at master before 
preparing Red Arrow. See also:
   
     * For Apache Arrow C++: 
https://arrow.apache.org/docs/developers/cpp/building.html
     * For Apache Arrow GLib: 
https://github.com/apache/arrow/blob/master/c_glib/README.md
   
   ```

##########
File path: ruby/red-arrow/README.md
##########
@@ -50,3 +50,20 @@ table = Arrow::Table.load("/dev/shm/data.arrow")
 # Process data in table
 table.save("/dev/shm/data-processed.arrow")
 ```
+
+## development
+```
+$ cd ruby/red-arrow
+$ bundle install
+$ bundle exec rake test
+```
+
+### Mac OS

Review comment:
       ```suggestion
   ### For macOS with Homebrew
   
   ```

##########
File path: ruby/red-arrow/README.md
##########
@@ -50,3 +50,20 @@ table = Arrow::Table.load("/dev/shm/data.arrow")
 # Process data in table
 table.save("/dev/shm/data-processed.arrow")
 ```
+
+## development
+```

Review comment:
       ```suggestion
   ```console
   ```

##########
File path: ruby/red-arrow/README.md
##########
@@ -50,3 +50,20 @@ table = Arrow::Table.load("/dev/shm/data.arrow")
 # Process data in table
 table.save("/dev/shm/data-processed.arrow")
 ```
+
+## development
+```
+$ cd ruby/red-arrow
+$ bundle install
+$ bundle exec rake test
+```
+
+### Mac OS
+```

Review comment:
       ```suggestion
   ```console
   ```

##########
File path: ruby/red-arrow/README.md
##########
@@ -50,3 +50,20 @@ table = Arrow::Table.load("/dev/shm/data.arrow")
 # Process data in table
 table.save("/dev/shm/data-processed.arrow")
 ```
+
+## development
+```
+$ cd ruby/red-arrow
+$ bundle install
+$ bundle exec rake test
+```
+
+### Mac OS
+```
+$ cd ruby/red-arrow
+$ bundle install
+$ brew install apache-arrow --head
+$ brew install apache-arrow-glib --head
+$ export PKG_CONFIG_PATH="/opt/homebrew/opt/openssl@1.1/lib/pkgconfig"

Review comment:
       Can we remove this with the following patch?
   
   ```diff
   diff --git a/ruby/red-arrow/ext/arrow/extconf.rb 
b/ruby/red-arrow/ext/arrow/extconf.rb
   index 5ba9f4c2e..9e92bd316 100644
   --- a/ruby/red-arrow/ext/arrow/extconf.rb
   +++ b/ruby/red-arrow/ext/arrow/extconf.rb
   @@ -25,6 +25,19 @@ if arrow_pkg_config_path
      ENV["PKG_CONFIG_PATH"] = pkg_config_paths.join(File::PATH_SEPARATOR)
    end
    
   +checking_for(checking_message("Homebrew")) do
   +  platform = NativePackageInstaller::Platform.detect
   +  if platform.is_a?(NativePackageInstaller::Platform::Homebrew)
   +    openssl_prefix = `brew --prefix openssl@1.1`.chomp
   +    unless openssl_prefix.empty?
   +      PKGConfig.add_path("#{openssl_prefix}/lib/pkgconfig")
   +    end
   +    true
   +  else
   +    false
   +  end
   +end
   +
    unless required_pkg_config_package([
                                         "arrow",
                                         Arrow::Version::MAJOR,
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org