houqp commented on a change in pull request #1023: URL: https://github.com/apache/arrow-datafusion/pull/1023#discussion_r711823360
########## File path: datafusion/src/physical_plan/hash_join.rs ########## @@ -188,7 +182,8 @@ impl HashJoinExec { let right_schema = right.schema(); check_join_is_valid(&left_schema, &right_schema, &on)?; - let schema = Arc::new(build_join_schema(&left_schema, &right_schema, join_type)); + let (schema, column_indices) = + build_join_schema(&left_schema, &right_schema, join_type); Review comment: column indices are now created only once when we create the HashJoinExec node. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org