[GitHub] [arrow-datafusion] francis-du commented on a change in pull request #1055: fix: joins on TimestampMillisecond columns

[GitBox]

francis-du commented on a change in pull request #1055:
URL: https://github.com/apache/arrow-datafusion/pull/1055#discussion_r716329581



##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -781,7 +782,7 @@ fn equal_rows(
             DataType::Float32 => equal_rows_elem!(Float32Array, l, r, left, 
right),
             DataType::Float64 => equal_rows_elem!(Float64Array, l, r, left, 
right),
             DataType::Timestamp(_, None) => {
-                equal_rows_elem!(Int64Array, l, r, left, right)
+                equal_rows_elem!(TimestampNanosecondArray, l, r, left, right)

Review comment:
       I think other units need to first support the data types of these units 
in the Schema. And there is an issue about join on the 
`Time64(TimeUnit::Millisecond)` columns. I am analyzing this issue, and then I 
will open an issue and fix it.
   
   
![image](https://user-images.githubusercontent.com/25944814/134839707-e66c795e-f2a6-458d-a2a0-e7b8ca8510f9.png)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org