cyb70289 commented on a change in pull request #11376:
URL: https://github.com/apache/arrow/pull/11376#discussion_r725774518
##########
File path: cpp/src/arrow/util/utf8_util_benchmark.cc
##########
@@ -24,6 +24,15 @@
#include "arrow/testing/gtest_util.h"
#include "arrow/util/utf8.h"
+// Do not benchmark inlined functions directly inside the benchmark loop
+static ARROW_NOINLINE bool ValidateUTF8NoInline(const uint8_t* data, int64_t
size) {
Review comment:
Without this noinline wrap, benchmarked function is expanded in the
benchmark loop.
It causes strange behaviour. E.g., an obviously irrelevant change may bring
big variance to the benchmark result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
