Jimexist commented on a change in pull request #1111:
URL: https://github.com/apache/arrow-datafusion/pull/1111#discussion_r727613072
##########
File path: python/src/context.rs
##########
@@ -84,10 +83,7 @@ impl ExecutionContext {
// generate a random (unique) name for this table
// table name cannot start with numeric digit
- let name = std::iter::once('c')
- .chain(rand::thread_rng().sample_iter(&Alphanumeric))
- .take(10)
- .collect::<String>();
+ let name = "c".to_owned() + &Uuid::new_v4().to_simple().to_string();
Review comment:
can you help add unit test? also the to_simple seems to produce [upper
case string][1]
[1]: https://docs.rs/uuid/0.8.2/uuid/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
