hippowdon commented on a change in pull request #1111:
URL: https://github.com/apache/arrow-datafusion/pull/1111#discussion_r728378755



##########
File path: python/src/context.rs
##########
@@ -84,10 +83,7 @@ impl ExecutionContext {
 
         // generate a random (unique) name for this table
         // table name cannot start with numeric digit
-        let name = std::iter::once('c')
-            .chain(rand::thread_rng().sample_iter(&Alphanumeric))
-            .take(10)
-            .collect::<String>();
+        let name = "c".to_owned() + &Uuid::new_v4().to_simple().to_string();

Review comment:
       @Jimexist Thank you for your comment. I have added another commit with 
two changes - convert UUID table name part to lower case and also I added a 
test (in Python) to ensure that create_dataframe() registers newly created 
table and its table name is as expected.
   If you are ok with the change, I will squash the commits to clean the branch 
before the merge.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to