matthewmturner commented on a change in pull request #1126:
URL: https://github.com/apache/arrow-datafusion/pull/1126#discussion_r730036921
##########
File path: datafusion/tests/sql.rs
##########
@@ -1276,13 +1312,18 @@ async fn query_cast_timestamp_millis() -> Result<()> {
ctx.register_table("t1", Arc::new(t1_table))?;
let sql = "SELECT to_timestamp_millis(ts) FROM t1 LIMIT 3";
- let actual = execute(&mut ctx, sql).await;
+ let actual = execute_to_batches(&mut ctx, sql).await;
+
let expected = vec![
- vec!["2009-03-01 00:00:00"],
- vec!["2009-03-01 00:01:00"],
- vec!["2009-04-01 00:00:00"],
+ "+--------------------------+",
+ "| totimestampmillis(t1.ts) |",
+ "+--------------------------+",
+ "| 2009-03-01 00:00:00 |",
+ "| 2009-03-01 00:01:00 |",
+ "| 2009-04-01 00:00:00 |",
+ "+--------------------------+",
Review comment:
@alamb this test seems to be testing for milliseconds but the results
dont have that much precision. should the test be updated to get to the
appropriate precision? similar question for the microsecond test beneath this
one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
