alamb commented on a change in pull request #1126:
URL: https://github.com/apache/arrow-datafusion/pull/1126#discussion_r736501280
##########
File path: datafusion/tests/sql.rs
##########
@@ -1411,43 +1501,55 @@ async fn query_cast_timestamp_micros_to_others() ->
Result<()> {
// Original column is micros, convert to millis and check timestamp
let sql = "SELECT to_timestamp_millis(ts) FROM ts_micros LIMIT 3";
- let actual = execute(&mut ctx, sql).await;
+ let actual = execute_to_batches(&mut ctx, sql).await;
let expected = vec![
- vec!["2020-09-08 13:42:29.190"],
- vec!["2020-09-08 12:42:29.190"],
- vec!["2020-09-08 11:42:29.190"],
+ "+---------------------------------+",
+ "| totimestampmillis(ts_micros.ts) |",
Review comment:
this column name is fascinating -- it seem like it should be
`to_timestamp_millis(..)` but I'll let someone else file a ticket if it is
important to them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
