dragosmg commented on pull request #11403:
URL: https://github.com/apache/arrow/pull/11403#issuecomment-945798743
A more general comment. Would it make sense to replace `expect_equal()` with
`expect_identical()` inside `expect_dplyr_equal()`? I feel Arrow is quite
strict about type and we're not enforcing a strict check for equivalence with a
dplyr call.
For example, I was surprised to see the {dplyr} call returning an integer
and the equivalent {arrow} call returning a double. That's due to
`expect_equal()` being less strict than `expect_identical()` - i.e. it has a
built in tolerance when checking values (small floating point differences are
ignored). This implies that `1L` and `1` are treated as equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
