coryan commented on a change in pull request #11436:
URL: https://github.com/apache/arrow/pull/11436#discussion_r732205470
##########
File path: cpp/src/arrow/filesystem/gcsfs.cc
##########
@@ -58,9 +61,48 @@ struct GcsPath {
}
};
-} // namespace
+class GcsInputStream : public arrow::io::InputStream {
+ public:
+ explicit GcsInputStream(gcs::ObjectReadStream stream) :
stream_(std::move(stream)) {}
-namespace gcs = google::cloud::storage;
+ ~GcsInputStream() override = default;
+
+ Status Close() override {
+ stream_.Close();
Review comment:
Starting with v1.32.0 they are idempotent. Created
[ARROW-14385](https://issues.apache.org/jira/browse/ARROW-14385) to remind
myself of updating any dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
