coryan commented on a change in pull request #11436:
URL: https://github.com/apache/arrow/pull/11436#discussion_r732206952
##########
File path: cpp/src/arrow/filesystem/gcsfs.cc
##########
@@ -58,9 +61,48 @@ struct GcsPath {
}
};
-} // namespace
+class GcsInputStream : public arrow::io::InputStream {
+ public:
+ explicit GcsInputStream(gcs::ObjectReadStream stream) :
stream_(std::move(stream)) {}
-namespace gcs = google::cloud::storage;
+ ~GcsInputStream() override = default;
+
+ Status Close() override {
+ stream_.Close();
+ return Status::OK();
+ }
+
+ Result<int64_t> Tell() const override {
+ if (!stream_) {
Review comment:
In the other methods an invalid stream would result in an error anyway.
Happy to add the additional checks if you think they make the code easier to
grok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
