bkmgit commented on a change in pull request #11529:
URL: https://github.com/apache/arrow/pull/11529#discussion_r735167612
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -423,7 +423,9 @@ test_js() {
fi
yarn --frozen-lockfile
- yarn run-s clean:all lint build
+ yarn run-s clean:all
+ yarn run-s lint
+ yarn run-s build
Review comment:
yarn run-s clean:all lint build
seemed not to work for me when using the verify-release-candidate.sh script.
Perhaps one can add
`npm install npm-run-all --save-dev`
or
`yarn add npm-run-all --dev`
not sure if this package is installed by default with node on all systems
using the commands in the script
```bash
if [ "${INSTALL_NODE}" -gt 0 ]; then
export NVM_DIR="`pwd`/.nvm"
mkdir -p $NVM_DIR
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh
| \
PROFILE=/dev/null bash
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
nvm install --lts
npm install -g yarn
fi
```
At least on the systems I tried, it was not installed by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
