jonkeane commented on pull request #11592: URL: https://github.com/apache/arrow/pull/11592#issuecomment-957908069
This is looking good. On `lubridate::is.POSIXt()` being more niche, I think we might want them. I implemented [a (hacky) version](https://github.com/apache/arrow/blob/a0c650415bc28920512077faecdfa9d07d3c4efe/r/R/dplyr-functions.R#L258-L261) of that in order to [prevent dates from getting timestamped in `strftime`](https://github.com/apache/arrow/blob/a0c650415bc28920512077faecdfa9d07d3c4efe/r/R/dplyr-functions.R#L776-L782). What about them were you thinking would be confusing? The name `is_timestamp` doesn't need to remain the same, I purposely didn't use `lubridate::is.POSIXt()` since we would come back, but if we can + want to use that instead here that would be totally fine! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
