ianmcook commented on a change in pull request #11592:
URL: https://github.com/apache/arrow/pull/11592#discussion_r741201435
##########
File path: r/R/dplyr-functions.R
##########
@@ -848,6 +848,21 @@ nse_funcs$wday <- function(x,
Expression$create("day_of_week", x, options = list(count_from_zero = FALSE,
week_start = week_start))
}
+nse_funcs$is.Date <- function(x) {
+ lubridate::is.Date(x) ||
Review comment:
lubridate isn't in the arrow imports or depends so I don't think we can
call lubridate functions it like this. I think we need to use `class()` or
`inherits()` to determine if `x` is a lubridate object when `x` is an R object
not an arrow object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
